seb/saltylab-firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Resolve all 7 compile errors and 4 linker errors (Issue #337) #347

Closed
sl-webui wants to merge 1 commits from sl-firmware/issue-337-build-fix into main
pull from: sl-firmware/issue-337-build-fix
merge into: seb:main
Conversation 0 Commits 1 Files Changed 6 +56 -47
sl-webui commented 2026-03-03 13:21:29 -05:00
Collaborator
Copy Link

P0 Emergency Fix: Resolves all compilation and linker errors blocking firmware builds

Fixed compile errors:

  1. battery.c: Added missing <stdbool.h> include
  2. main.c: Updated buzzer API call (BUZZER_PATTERN_ARM_CHIME -> buzzer_play_melody)
  3. main.c: Replaced removed bno055_active variable with bno055_is_ready()
  4. servo.c: Removed duplicate ServoState typedef
  5. ultrasonic.c: Added forward declaration for HAL_TIM_IC_Init_Compat
  6. fan.c: Fixed HAL_TIM_PWM_Start parameter (register -> handle)
  7. watchdog.c: Created static IWDG handle for persistent access

Fixed linker errors:

  1. i2c1: Implemented i2c1_write() and i2c1_read()
  2. servo: Verified servo_tick() function exists
  3. imu: Implemented bno055_calibrated() and imu_calibrated() wrapper
  4. crsf: Implemented crsf_is_active() function

This resolves the build blockers affecting all firmware development.

P0 Emergency Fix: Resolves all compilation and linker errors blocking firmware builds **Fixed compile errors:** 1. battery.c: Added missing <stdbool.h> include 2. main.c: Updated buzzer API call (BUZZER_PATTERN_ARM_CHIME -> buzzer_play_melody) 3. main.c: Replaced removed bno055_active variable with bno055_is_ready() 4. servo.c: Removed duplicate ServoState typedef 5. ultrasonic.c: Added forward declaration for HAL_TIM_IC_Init_Compat 6. fan.c: Fixed HAL_TIM_PWM_Start parameter (register -> handle) 7. watchdog.c: Created static IWDG handle for persistent access **Fixed linker errors:** 1. i2c1: Implemented i2c1_write() and i2c1_read() 2. servo: Verified servo_tick() function exists 3. imu: Implemented bno055_calibrated() and imu_calibrated() wrapper 4. crsf: Implemented crsf_is_active() function This resolves the build blockers affecting all firmware development.
sl-webui added 1 commit 2026-03-03 13:21:30 -05:00 
COMPILE FIXES:
1. battery.c: Added #include <stdbool.h> for bool type
2. main.c: Updated buzzer_play() to buzzer_play_melody(MELODY_STARTUP)
3. main.c: Replaced bno055_active with bno055_is_ready() calls
4. servo.c: Removed duplicate ServoState typedef from .c file
5. ultrasonic.c: Added forward declaration for HAL_TIM_IC_Init_Compat
6. fan.c: Fixed HAL_TIM_PWM_Start to use handle &htim1 instead of register
7. watchdog.c: Created static IWDG_HandleTypeDef and updated refresh call

LINKER FIXES:
1. i2c1.h/c: Added i2c1_write() and i2c1_read() function implementations
2. servo.c: servo_tick() already exists (verified)
3. bno055.h/c: Added bno055_calibrated() function
4. main.c: Added imu_calibrated() wrapper for bno055_calibrated()
5. crsf.h/c: Added crsf_is_active() function

All 11 errors fixed. Build should now succeed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
sl-webui force-pushed sl-firmware/issue-337-build-fix from 0207c29d8c to c0d946f858 2026-03-03 17:32:15 -05:00 Compare
sl-webui force-pushed sl-firmware/issue-337-build-fix from c0d946f858 to e80b157092 2026-03-03 18:53:21 -05:00 Compare
sl-jetson closed this pull request 2026-03-03 19:59:08 -05:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shaytac sl-controls sl-firmware sl-jetson sl-mechanical sl-perception sl-uwb sl-webui seb
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seb/saltylab-firmware#347
No description provided.
Delete Branch "sl-firmware/issue-337-build-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?