seb/saltylab-firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add phone bridge and GPS topics to rosbridge whitelist (Issue #681) #721

Merged
sl-jetson merged 2 commits from sl-webui/issue-681-fix-gps-topics into main 2026-04-04 11:15:13 -04:00
Conversation 0 Commits 2 Files Changed 1 +8 -2
sl-jetson commented 2026-04-04 10:56:52 -04:00
Collaborator
Copy Link

Summary

  • Add /saltybot/phone/gps, /saltybot/phone/imu, /saltybot/phone/battery, /saltybot/phone/bridge/status to topics_glob — required for phone bridge GPS data to reach the browser dashboard
  • Add /gps/fix, /gps/vel for standard ROS GPS topic passthrough
  • Companion fix to PR #720 (GPS tracker topic fix by sl-webui)

Test plan

  • rosbridge restarts cleanly with updated params
  • Browser GPS dashboard receives /saltybot/phone/gps data
  • /gps/fix visible in roslibjs topic list

🤖 Generated with Claude Code

## Summary - Add /saltybot/phone/gps, /saltybot/phone/imu, /saltybot/phone/battery, /saltybot/phone/bridge/status to topics_glob — required for phone bridge GPS data to reach the browser dashboard - Add /gps/fix, /gps/vel for standard ROS GPS topic passthrough - Companion fix to PR #720 (GPS tracker topic fix by sl-webui) ## Test plan - [ ] rosbridge restarts cleanly with updated params - [ ] Browser GPS dashboard receives /saltybot/phone/gps data - [ ] /gps/fix visible in roslibjs topic list 🤖 Generated with Claude Code
sl-jetson added 1 commit 2026-04-04 10:56:52 -04:00 
Add /saltybot/phone/gps, /saltybot/phone/imu, /saltybot/phone/battery,
/saltybot/phone/bridge/status, /gps/fix, /gps/vel to topics_glob so
the browser GPS dashboard can receive phone-bridged GPS data.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sl-jetson added 1 commit 2026-04-04 10:58:11 -04:00 
rclpy expects DOUBLE for this param; integer 0 raises InvalidParameterTypeException.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sl-jetson merged commit dd8afb480f into main 2026-04-04 11:15:13 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shaytac sl-controls sl-firmware sl-jetson sl-mechanical sl-perception sl-uwb sl-webui seb
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seb/saltylab-firmware#721
No description provided.
Delete Branch "sl-webui/issue-681-fix-gps-topics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?