seb/saltylab-firmware
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

bug(social_msgs): MeshPeer.msg uses C++ reserved keyword namespace — build fails #392

New Issue
Closed
opened 2026-03-04 12:37:58 -05:00 by seb · 0 comments
seb commented 2026-03-04 12:37:58 -05:00
Owner
Copy Link

Bug

saltybot_social_msgs fails to build because MeshPeer.msg uses namespace as a field name, which is a C++ reserved keyword. The rosidl code generator emits namespace as a struct member, causing every C++ compilation unit to fail.

Error

mesh_peer__struct.h:45:28: error: expected unqualified-id before 'namespace'
   45 |   rosidl_runtime_c__String namespace;

Fix Required

Rename field namespace to ros_namespace in:

  1. jetson/ros2_ws/src/saltybot_social_msgs/msg/MeshPeer.msg
  2. jetson/ros2_ws/src/saltybot_social/saltybot_social/mesh_comms_node.py (line 181: msg.namespace → msg.ros_namespace)

Impact

P0 build-blocker. No package depending on saltybot_social_msgs can compile. Blocks all social stack testing on hardware.

Verified

Fix tested on Orin Nano Super — clean build after rename.

Reported by: Salty (integration testing on Orin)

## Bug `saltybot_social_msgs` fails to build because `MeshPeer.msg` uses `namespace` as a field name, which is a **C++ reserved keyword**. The rosidl code generator emits `namespace` as a struct member, causing every C++ compilation unit to fail. ### Error ``` mesh_peer__struct.h:45:28: error: expected unqualified-id before 'namespace' 45 | rosidl_runtime_c__String namespace; ``` ### Fix Required Rename field `namespace` to `ros_namespace` in: 1. `jetson/ros2_ws/src/saltybot_social_msgs/msg/MeshPeer.msg` 2. `jetson/ros2_ws/src/saltybot_social/saltybot_social/mesh_comms_node.py` (line 181: `msg.namespace` → `msg.ros_namespace`) ### Impact **P0 build-blocker.** No package depending on `saltybot_social_msgs` can compile. Blocks all social stack testing on hardware. ### Verified Fix tested on Orin Nano Super — clean build after rename. Reported by: Salty (integration testing on Orin)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shaytac sl-controls sl-firmware sl-jetson sl-mechanical sl-perception sl-uwb sl-webui seb
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seb/saltylab-firmware#392
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?