66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
64 lines
2.1 KiB
Python
64 lines
2.1 KiB
Python
"""Tests for Discord channel_skill_bindings auto-skill resolution."""
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
def _make_adapter():
|
|
"""Create a minimal DiscordAdapter with mocked config."""
|
|
from plugins.platforms.discord.adapter import DiscordAdapter
|
|
adapter = object.__new__(DiscordAdapter)
|
|
adapter.config = MagicMock()
|
|
adapter.config.extra = {}
|
|
return adapter
|
|
|
|
|
|
class TestResolveChannelSkills:
|
|
def test_no_bindings_returns_none(self):
|
|
adapter = _make_adapter()
|
|
assert adapter._resolve_channel_skills("123") is None
|
|
|
|
def test_match_by_channel_id(self):
|
|
adapter = _make_adapter()
|
|
adapter.config.extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "100", "skills": ["skill-a", "skill-b"]},
|
|
]
|
|
}
|
|
assert adapter._resolve_channel_skills("100") == ["skill-a", "skill-b"]
|
|
|
|
def test_match_by_parent_id(self):
|
|
adapter = _make_adapter()
|
|
adapter.config.extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "200", "skills": ["forum-skill"]},
|
|
]
|
|
}
|
|
# channel_id doesn't match, but parent_id does (forum thread)
|
|
assert adapter._resolve_channel_skills("999", parent_id="200") == ["forum-skill"]
|
|
|
|
def test_no_match_returns_none(self):
|
|
adapter = _make_adapter()
|
|
adapter.config.extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "100", "skills": ["skill-a"]},
|
|
]
|
|
}
|
|
assert adapter._resolve_channel_skills("999") is None
|
|
|
|
def test_single_skill_string(self):
|
|
adapter = _make_adapter()
|
|
adapter.config.extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "100", "skill": "solo-skill"},
|
|
]
|
|
}
|
|
assert adapter._resolve_channel_skills("100") == ["solo-skill"]
|
|
|
|
def test_dedup_preserves_order(self):
|
|
adapter = _make_adapter()
|
|
adapter.config.extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "100", "skills": ["a", "b", "a", "c", "b"]},
|
|
]
|
|
}
|
|
assert adapter._resolve_channel_skills("100") == ["a", "b", "c"]
|