1c68f6f81f
gateway/run.py is the largest god file (20k LOC, GatewayRunner with 220
methods). This lifts the cohesive kanban-watcher cluster — _kanban_notifier_watcher,
_kanban_dispatcher_watcher, _kanban_advance/unsub/rewind, _deliver_kanban_artifacts
(~1,035 LOC, 6 methods) — into gateway/kanban_watchers.py as a mixin that
GatewayRunner inherits.
Mixin (not free functions) because the methods use only self state: inheriting
keeps every self._kanban_* call site working unchanged via the MRO, making this
a behavior-neutral move. The methods' lazy imports (_kb, _decomp, _load_config,
Platform) travel with them; the mixin needs only stdlib + a matching
logging.getLogger('gateway.run').
run.py 20187 -> 19157 LOC; GatewayRunner direct methods 220 -> 214.
Behavior-neutral: gateway test suite 6582 passed / 0 failed; start() still wires
both watchers via self._kanban_*; MRO resolves all 6 to the mixin. One test
(corrupt-board quarantine retry) keyed its time-travel mock on the caller's
filename being gateway/run.py — updated to also accept gateway/kanban_watchers.py.
Establishes the mixin-extraction pattern for further GatewayRunner decomposition
(the 2406-LOC _run_agent and 1164-LOC _handle_message remain, but their callback
closures need a context-object redesign — deferred).
46 lines
1.6 KiB
Python
46 lines
1.6 KiB
Python
"""Tests for the extracted GatewayKanbanWatchersMixin (god-file Phase 3).
|
|
|
|
The kanban watcher loops were lifted out of gateway/run.py into a mixin that
|
|
GatewayRunner inherits. These tests confirm the mixin exposes the methods and
|
|
that GatewayRunner picks them up via the MRO (behavior-neutral relocation).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import inspect
|
|
|
|
from gateway.kanban_watchers import GatewayKanbanWatchersMixin
|
|
|
|
KANBAN_METHODS = [
|
|
"_kanban_notifier_watcher",
|
|
"_kanban_dispatcher_watcher",
|
|
"_kanban_advance",
|
|
"_kanban_unsub",
|
|
"_kanban_rewind",
|
|
"_deliver_kanban_artifacts",
|
|
]
|
|
|
|
|
|
def test_mixin_defines_kanban_methods():
|
|
for m in KANBAN_METHODS:
|
|
assert hasattr(GatewayKanbanWatchersMixin, m), f"mixin missing {m}"
|
|
|
|
|
|
def test_gateway_runner_inherits_mixin():
|
|
# Import here so a heavy gateway import only happens if the first test passed.
|
|
from gateway.run import GatewayRunner
|
|
|
|
assert issubclass(GatewayRunner, GatewayKanbanWatchersMixin)
|
|
# Each kanban method resolves to the mixin's implementation via the MRO.
|
|
for m in KANBAN_METHODS:
|
|
owner = next(c for c in GatewayRunner.__mro__ if m in c.__dict__)
|
|
assert owner is GatewayKanbanWatchersMixin, (
|
|
f"{m} resolved to {owner.__name__}, expected the mixin"
|
|
)
|
|
|
|
|
|
def test_watcher_loops_are_coroutines():
|
|
# The two long-running watchers are async loops.
|
|
assert inspect.iscoroutinefunction(GatewayKanbanWatchersMixin._kanban_notifier_watcher)
|
|
assert inspect.iscoroutinefunction(GatewayKanbanWatchersMixin._kanban_dispatcher_watcher)
|