Ben
034ad95fed
fix(dashboard-auth): propagate next= through login page + PKCE cookie
...
The gate's _unauth_response set next=<path> on the /login redirect URL,
but nothing downstream read it: render_login_html ignored next=,
auth_login dropped it, and auth_callback read next= from its own query
string — which an IDP never sets on the callback URL (real IDPs only
echo back code+state). The _validate_post_login_target plumbing in the
callback was unreachable on the happy path, so users always landed on
"/" regardless of what they originally requested.
Worse: reading next= from the callback URL was a latent open-redirect
sink, since an attacker could craft /auth/callback?...&next=/admin and
have the server honour it post-auth.
Fix carries next= through the round trip on a server-controlled channel:
1. login_page reads request.query_params['next'] and passes it (post-
validation) to render_login_html.
2. render_login_html threads next= URL-encoded into each provider
button's href, with HTML-attribute escaping as defence in depth.
3. auth_login accepts ?next= as a query param, re-validates, and
appends it as a fourth segment (next=<urlquoted>) in the PKCE
cookie payload alongside provider/state/verifier.
4. auth_callback no longer accepts a next: str = "" query param. It
parses next= out of the PKCE cookie and validates that with the
same same-origin rules. Any attacker-supplied ?next= on the
callback URL is silently ignored — server-only carrier.
Test coverage adds three classes:
- TestAuthCallbackNext drives /login → /auth/login → IDP-bounce →
/auth/callback end-to-end without smuggling next= onto the callback
URL (which is what the previous tests did and why they didn't
catch the bug). Includes test_attacker_callback_next_param_is_ignored
to pin the security property that the URL value is never read.
- TestRenderLoginHtmlNext covers the rendering function at the
unit boundary so a regression that drops next_path is caught
without spinning up the full app.
- TestAuthLoginPkceCookieNext inspects the Set-Cookie header on
/auth/login responses so a regression in cookie encoding is caught
without driving the full round trip.
Mutation-tested: reverting auth_callback to read next= from the URL
trips 3 of 6 TestAuthCallbackNext tests (the safe-path and attacker-
hardening ones), confirming the suite discriminates between the cookie
read and the URL read.
2026-05-27 02:12:27 -07:00
..
2026-02-26 03:20:08 +03:00
2026-05-27 02:12:27 -07:00
2026-05-19 11:10:51 -07:00
2026-05-25 01:20:33 -07:00
2026-05-25 01:20:33 -07:00
2026-04-07 17:19:07 -07:00
2026-05-27 00:43:32 -07:00
2026-04-26 05:43:31 -07:00
2026-05-09 11:10:53 -07:00
2026-05-27 00:43:32 -07:00
2026-05-23 21:03:51 -07:00
2026-04-21 14:31:48 -05:00
2026-04-07 17:19:07 -07:00
2026-04-07 17:19:07 -07:00
2026-04-24 04:53:32 -07:00
2026-05-25 01:23:31 -07:00
2026-05-18 10:26:55 -07:00
2026-05-18 20:10:52 -07:00
2026-05-17 16:56:37 -07:00
2026-05-06 13:29:54 -07:00
2026-04-14 01:43:45 -07:00
2026-05-23 17:47:36 -07:00
2026-04-24 03:00:33 -07:00
2026-05-08 14:27:40 -07:00
2026-05-24 04:25:32 -07:00
2026-05-19 14:51:21 -07:00
2026-05-18 20:01:34 -07:00
2026-05-18 10:14:38 -07:00
2026-05-18 10:14:38 -07:00
2026-05-25 05:07:52 -07:00
2026-04-07 17:59:42 -07:00
2026-05-15 14:45:43 -07:00
2026-03-18 03:17:37 -07:00
2026-04-23 23:28:34 -07:00
2026-05-13 17:32:22 -07:00
2026-05-18 21:38:05 -07:00
2026-04-09 16:24:53 -07:00
2026-04-29 23:18:55 -07:00
2026-04-11 01:52:58 -07:00
2026-05-25 01:20:33 -07:00
2026-05-21 02:14:08 -04:00
2026-03-09 21:36:29 -07:00
2026-05-09 23:17:25 -07:00
2026-05-09 23:17:25 -07:00
2026-05-15 02:31:30 -07:00
2026-05-17 02:29:41 -07:00
2026-05-20 19:14:21 -07:00
2026-05-13 09:34:15 -07:00
2026-04-21 14:23:45 -07:00
2026-04-29 23:18:55 -07:00
2026-04-17 19:03:26 -07:00
2026-04-28 01:40:25 -07:00
2026-05-25 15:07:19 -07:00
2026-04-29 23:18:55 -07:00
2026-05-24 18:05:33 -07:00
2026-04-10 03:44:43 -07:00
2026-04-28 01:18:09 -07:00
2026-04-24 05:09:08 -07:00
2026-04-24 03:33:29 -07:00
2026-04-24 05:09:08 -07:00
2026-05-18 17:39:50 +00:00
2026-05-05 05:15:54 -07:00
2026-05-09 18:43:40 -07:00
2026-05-07 05:27:47 -07:00
2026-05-07 05:27:47 -07:00
2026-05-21 23:40:58 -07:00
2026-04-25 18:47:53 -07:00
2026-05-19 14:50:38 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-05-27 02:12:27 -07:00
2026-04-30 06:43:22 -04:00
2026-04-30 02:30:20 -07:00
2026-05-12 13:59:22 -04:00
2026-05-24 15:43:48 -07:00
2026-05-18 16:34:24 +05:30
2026-04-16 06:48:33 -07:00
2026-05-09 11:04:46 -07:00
2026-04-20 22:14:29 -07:00
2026-04-20 22:14:29 -07:00
2026-04-17 05:08:07 -07:00
2026-05-03 03:25:45 -07:00
2026-04-14 23:13:11 -07:00
2026-05-09 13:36:33 -07:00
2026-05-27 00:43:32 -07:00
2026-05-13 18:40:14 -07:00
2026-05-23 17:17:05 -07:00
2026-05-04 15:31:15 -04:00
2026-05-23 05:24:57 -07:00
2026-04-09 16:24:53 -07:00
2026-05-12 15:06:25 -07:00
2026-05-09 17:54:17 -07:00
2026-03-14 12:11:23 -07:00
2026-05-24 18:05:33 -07:00
2026-05-15 14:45:43 -07:00
2026-05-19 17:27:24 -07:00
2026-05-19 11:23:15 -07:00
2026-05-19 17:27:24 -07:00
2026-05-19 11:23:15 -07:00
2026-04-24 04:46:17 -07:00
2026-04-20 23:20:33 -07:00
2026-05-27 00:43:32 -07:00
2026-05-13 22:55:09 -07:00
2026-04-20 20:53:51 -07:00
2026-04-29 20:33:29 -07:00
2026-05-22 04:10:45 -07:00
2026-05-21 19:17:45 -07:00
2026-05-13 22:31:11 -07:00
2026-05-19 17:26:23 -07:00
2026-05-18 20:17:10 -07:00
2026-05-18 21:33:08 -07:00
2026-05-19 01:28:32 -07:00
2026-05-18 20:17:48 -07:00
2026-05-24 15:48:58 -07:00
2026-05-18 09:40:44 -07:00
2026-05-18 20:26:02 -07:00
2026-05-18 20:47:01 -07:00
2026-05-23 02:34:34 -07:00
2026-05-23 23:10:36 -07:00
2026-05-07 13:04:41 -07:00
2026-05-07 13:04:41 -07:00
2026-05-18 21:10:12 -07:00
2026-03-29 21:54:36 -07:00
2026-05-06 03:50:59 -07:00
2026-04-11 17:23:36 -07:00
2026-05-19 01:28:32 -07:00
2026-05-07 05:17:03 -07:00
2026-05-26 12:48:14 -07:00
2026-05-07 05:17:03 -07:00
2026-04-29 21:56:47 -07:00
2026-05-26 12:48:14 -07:00
2026-05-17 02:29:41 -07:00
2026-05-20 09:18:23 -07:00
2026-05-11 18:08:16 -07:00
2026-04-24 05:24:54 -07:00
2026-04-17 06:33:21 -07:00
2026-05-13 13:21:33 -07:00
2026-04-25 18:47:53 -07:00
2026-04-16 01:16:14 -07:00
2026-05-19 10:57:35 -07:00
2026-04-24 04:58:46 -07:00
2026-04-08 19:58:16 -07:00
2026-05-26 20:44:43 -07:00
2026-04-22 17:33:42 -07:00
2026-05-26 14:01:47 -07:00
2026-04-20 22:14:03 -07:00
2026-05-13 18:40:14 -07:00
2026-04-13 04:33:52 -07:00
2026-05-22 14:17:40 -07:00
2026-04-26 19:02:55 -07:00
2026-04-24 04:58:46 -07:00
2026-05-04 12:38:15 -07:00
2026-05-09 23:17:25 -07:00
2026-05-06 09:08:33 -07:00
2026-05-17 02:29:41 -07:00
2026-04-21 05:19:43 -07:00
2026-04-24 05:20:05 -07:00
2026-03-16 06:07:45 -07:00
2026-05-05 04:37:47 -07:00
2026-05-18 16:34:10 +05:30
2026-03-14 10:35:14 -07:00
2026-05-23 17:49:47 -07:00
2026-04-17 01:05:09 -07:00
2026-04-21 21:30:10 -07:00
2026-05-25 01:20:33 -07:00
2026-05-25 01:41:19 -07:00
2026-05-24 18:04:54 -07:00
2026-05-15 22:12:57 -07:00
2026-05-09 13:02:25 -07:00
2026-05-17 13:54:12 -07:00
2026-05-25 05:07:58 -07:00
2026-04-01 11:20:33 -07:00
2026-05-24 18:07:47 -07:00
2026-05-13 09:34:15 -07:00
2026-05-23 01:43:52 -07:00
2026-05-25 01:20:33 -07:00
2026-04-28 01:28:25 -07:00
2026-05-26 15:41:11 -07:00
2026-05-21 16:40:04 +05:30
2026-04-09 14:20:16 -07:00
2026-05-07 05:10:33 -07:00
2026-04-28 01:47:20 -07:00
2026-05-08 14:27:40 -07:00
2026-04-27 08:52:12 -07:00
2026-05-27 00:43:32 -07:00
2026-05-25 01:20:33 -07:00
2026-05-12 01:02:25 -07:00
2026-05-24 15:15:16 -07:00
2026-05-16 23:00:58 -05:00
2026-05-25 12:23:23 +10:00
2026-04-26 18:49:48 -07:00
2026-05-10 13:06:25 -07:00
2026-05-16 16:51:42 -07:00
2026-04-26 18:31:07 -07:00
2026-05-27 00:43:32 -07:00
2026-05-02 02:08:06 -07:00
2026-05-15 10:36:38 +05:30
2026-04-29 21:56:51 -07:00
2026-04-10 21:15:59 -07:00
2026-05-19 14:23:19 -07:00
2026-04-25 22:02:02 -07:00
2026-04-26 18:49:48 -07:00
2026-05-19 01:28:32 -07:00
2026-05-25 01:20:33 -07:00
2026-05-13 13:28:25 -07:00
2026-05-27 00:43:32 -07:00
2026-04-24 03:46:46 -07:00
2026-05-25 01:51:15 -07:00
2026-03-17 01:59:07 -07:00
2026-03-28 14:32:23 -07:00
2026-03-11 00:50:39 -07:00
2026-05-18 20:05:23 -07:00
2026-05-08 17:01:12 -07:00
2026-05-07 05:53:14 -07:00
2026-05-08 16:07:23 -07:00
2026-04-28 12:27:36 -07:00
2026-05-27 00:43:32 -07:00
2026-04-17 01:05:09 -07:00
2026-03-30 11:17:15 -07:00
2026-05-06 03:55:47 -07:00
2026-05-08 11:18:14 -07:00
2026-05-27 00:43:32 -07:00
2026-04-10 02:57:39 -07:00
2026-05-25 01:47:55 -07:00
2026-04-13 16:32:04 -07:00
2026-03-29 20:05:59 -07:00
2026-05-22 01:24:11 -07:00
2026-03-26 13:39:41 -07:00
2026-05-24 18:04:54 -07:00
2026-05-15 14:45:43 -07:00
2026-05-22 00:16:52 -05:00
2026-05-22 14:27:38 -07:00
2026-05-14 14:28:14 -07:00
2026-05-15 14:45:43 -07:00
2026-05-24 19:51:46 -07:00
2026-04-19 22:43:09 -07:00
2026-04-17 21:29:24 -07:00
2026-05-19 03:01:02 -07:00
2026-05-17 02:29:41 -07:00
2026-05-08 14:55:40 -07:00
2026-05-25 05:50:29 -07:00
2026-04-30 19:44:26 -07:00
2026-05-15 12:11:32 -07:00
2026-05-06 15:49:59 -07:00
2026-05-17 16:56:37 -07:00
2026-05-25 01:15:24 -07:00
2026-05-24 15:00:44 -07:00
2026-05-24 17:47:24 -07:00
2026-05-27 00:43:32 -07:00
2026-05-11 09:27:05 -07:00
2026-05-24 04:55:18 -07:00
2026-05-15 14:32:14 -07:00
2026-05-17 12:35:01 -07:00
2026-05-24 18:12:16 -07:00
2026-05-20 09:18:23 -07:00
2026-05-27 00:43:32 -07:00