seb/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

opentui(harden): slice the resume snapshot before mounting (no transient over-cap)

Browse Source 
commitSnapshot set the full fetched history then trimmed — briefly handing the
whole transcript to <For>. Since Yoga (WASM) layout memory is grow-only, even a
transient over-cap mount permanently ratchets the high-water mark, partly
defeating the cap when resuming a large session (a real one has ~1980 messages).
Slice to MESSAGE_CAP BEFORE the first setState so resume mounts at most the cap.
This commit is contained in:
alt-glitch 2026-06-09 09:41:37 +00:00
parent 52533bea09
commit c40d3172ac
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ui-tui-opentui-v2/src/logic/store.ts
View File

@ -780,9 +780,14 @@ export function createSessionStore() {
/** Replace history with the resume snapshot, then replay events buffered meanwhile. */ /** Replace history with the resume snapshot, then replay events buffered meanwhile. */
function commitSnapshot(snapshot: Message[]): void { function commitSnapshot(snapshot: Message[]): void {
setState('messages', snapshot) // Slice to the cap BEFORE the first setState, not after. Yoga (WASM) layout
// An over-cap resume snapshot must be trimmed too (it sets the whole array). // memory is grow-only, so even a TRANSIENT mount of an over-cap resume
setState(produce(capMessages)) // snapshot would permanently ratchet the high-water mark — a set-then-trim
// briefly hands the full fetched history to <For>. Pre-slicing guarantees
// resuming ANY session mounts at most MESSAGE_CAP rows. (Events buffered
// across the resume RPC, replayed below, self-cap via capMessages per push.)
const capped = snapshot.length > MESSAGE_CAP ? snapshot.slice(-MESSAGE_CAP) : snapshot
setState('messages', capped)
const pending = buffering ?? [] const pending = buffering ?? []
buffering = null buffering = null
for (const event of pending) applyNow(event) for (const event of pending) applyNow(event)