test(model-catalog): use exact URL equality in fallback tests
CodeQL flagged 'hermes-agent.nousresearch.com' in url and similar substring checks as py/incomplete-url-substring-sanitization. The rule is about URL allowlist checks in production code, not test routing — there's no security boundary here. Switch to url == self.PRIMARY / self.FALLBACK, which is the same semantic and silences the rule.
This commit is contained in:
@@ -206,7 +206,7 @@ class TestFallbackChain:
|
|||||||
|
|
||||||
def fake_fetch(url, timeout):
|
def fake_fetch(url, timeout):
|
||||||
calls.append(url)
|
calls.append(url)
|
||||||
if "hermes-agent.nousresearch.com" in url:
|
if url == self.PRIMARY:
|
||||||
return None # simulate Vercel 403
|
return None # simulate Vercel 403
|
||||||
return _valid_manifest()
|
return _valid_manifest()
|
||||||
|
|
||||||
@@ -245,7 +245,7 @@ class TestFallbackChain:
|
|||||||
|
|
||||||
def fake_fetch(url, timeout):
|
def fake_fetch(url, timeout):
|
||||||
calls.append(url)
|
calls.append(url)
|
||||||
if "hermes-agent.nousresearch.com" in url:
|
if url == self.PRIMARY:
|
||||||
return None
|
return None
|
||||||
return manifest
|
return manifest
|
||||||
|
|
||||||
@@ -253,7 +253,7 @@ class TestFallbackChain:
|
|||||||
result = model_catalog.get_catalog(force_refresh=True)
|
result = model_catalog.get_catalog(force_refresh=True)
|
||||||
|
|
||||||
assert result == manifest
|
assert result == manifest
|
||||||
assert any("raw.githubusercontent.com" in c for c in calls)
|
assert self.FALLBACK in calls
|
||||||
|
|
||||||
|
|
||||||
class TestCuratedAccessors:
|
class TestCuratedAccessors:
|
||||||
|
|||||||
Reference in New Issue
Block a user