fix(approval): catch perl/ruby -i as a separate flag token

The salvaged pattern matched -i only inside the first flag token, so
`perl -p -i -e '...' config.yaml` (the -i split out after -p) slipped
through. Widen to match a -...i flag token anywhere in the args; still
no false positive on `perl -e` code eval or config reads. Adds tests
for the separate-token, backup-suffix, and read-safe forms.
This commit is contained in:
Teknium
2026-06-04 05:36:30 -07:00
parent a6a4e6f9d7
commit b04c6e95f6
2 changed files with 30 additions and 1 deletions
+24
View File
@@ -449,6 +449,30 @@ class TestHermesConfigWriteProtection:
)
assert dangerous is True
def test_perl_in_place_separate_flag_token(self):
# The -i flag does not have to be the first token. `perl -p -i -e`
# splits the in-place flag out as its own token after -p; the pattern
# must catch it the same as `perl -i -pe`.
dangerous, key, desc = detect_dangerous_command(
"perl -p -i -e 's/approvals.mode: on/approvals.mode: off/' ~/.hermes/config.yaml"
)
assert dangerous is True
def test_perl_in_place_backup_suffix(self):
# `perl -i.bak` keeps a backup but still mutates the file in place.
dangerous, key, desc = detect_dangerous_command(
"perl -i.bak -pe 's/x/y/' ~/.hermes/config.yaml"
)
assert dangerous is True
def test_perl_eval_no_inplace_safe(self):
# `perl -e` with no -i flag is code evaluation, not file mutation —
# the perl/ruby -i pattern must not fire on it.
dangerous, key, desc = detect_dangerous_command(
"perl -wne 'print' ~/.hermes/config.yaml"
)
assert dangerous is False
def test_read_is_safe(self):
# Reading config is not a write — must not trip.
dangerous, key, desc = detect_dangerous_command("cat ~/.hermes/config.yaml")