Remove is_container check when restarting over dashboard (#46290)

Co-authored-by: IAvecilla <ignacio.avecilla@lambdaclass.com>
This commit is contained in:
Teknium
2026-06-15 11:09:23 +10:00
committed by GitHub
co-authored by IAvecilla
parent f3fe99863d
commit 4eb0ff639b
2 changed files with 24 additions and 3 deletions
+14
View File
@@ -69,6 +69,20 @@ def test_detect_service_manager_returns_known_value() -> None:
assert result in ("systemd", "launchd", "windows", "s6", "none")
def test_detect_service_manager_s6_keys_off_s6_running_not_is_container(
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Regression: Fly runs s6-overlay as PID 1 in a Firecracker microVM, which
is not a Docker/Podman container. Gating s6 detection on is_container() made
the dispatch path inert on Fly, so `hermes gateway restart` spawned a
foreground gateway that fought the supervised one. Detection must key off
s6 being PID 1 (`_s6_running`) alone."""
monkeypatch.setattr(
"hermes_cli.service_manager._s6_running", lambda: True,
)
assert detect_service_manager() == "s6"
# ---------------------------------------------------------------------------
# _s6_running — must work for unprivileged users, not just root
# ---------------------------------------------------------------------------