seb/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tests): type-correct OpenViking skill-scaffolding test sentinels

Browse Source
This commit is contained in:
kshitijk4poor
2026-06-17 23:44:31 +05:30
parent 49d7481dfb
commit 4de4a4e2da
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/openviking_plugin/test_openviking.py
+9 -5
View File
@@ -1,6 +1,7 @@
"""Tests for plugins/memory/openviking/__init__.py — URI normalization and payload handling.""" """Tests for plugins/memory/openviking/__init__.py — URI normalization and payload handling."""
import json import json
from typing import Any, cast
import plugins.memory.openviking as openviking_plugin import plugins.memory.openviking as openviking_plugin
from plugins.memory.openviking import OpenVikingMemoryProvider from plugins.memory.openviking import OpenVikingMemoryProvider
@@ -127,7 +128,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = [] RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient) monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider() provider = OpenVikingMemoryProvider()
provider._client = object() provider._client = cast(Any, object())
provider._endpoint = "http://openviking.test" provider._endpoint = "http://openviking.test"
provider._api_key = "" provider._api_key = ""
provider._account = "default" provider._account = "default"
@@ -143,6 +144,7 @@ class TestOpenVikingSkillQuerySafety:
) )
provider.queue_prefetch(skill_message) provider.queue_prefetch(skill_message)
assert provider._prefetch_thread is not None
provider._prefetch_thread.join(timeout=5.0) provider._prefetch_thread.join(timeout=5.0)
assert RecordingVikingClient.calls == [ assert RecordingVikingClient.calls == [
@@ -156,7 +158,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = [] RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient) monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider() provider = OpenVikingMemoryProvider()
provider._client = object() provider._client = cast(Any, object())
provider._endpoint = "http://openviking.test" provider._endpoint = "http://openviking.test"
provider._api_key = "" provider._api_key = ""
provider._account = "default" provider._account = "default"
@@ -173,6 +175,7 @@ class TestOpenVikingSkillQuerySafety:
) )
provider.queue_prefetch(skill_message) provider.queue_prefetch(skill_message)
assert provider._prefetch_thread is not None
provider._prefetch_thread.join(timeout=5.0) provider._prefetch_thread.join(timeout=5.0)
assert RecordingVikingClient.calls == [ assert RecordingVikingClient.calls == [
@@ -186,7 +189,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = [] RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient) monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider() provider = OpenVikingMemoryProvider()
provider._client = object() provider._client = cast(Any, object())
skill_message = ( skill_message = (
'[IMPORTANT: The user has invoked the "skill-creator" skill, indicating they want ' '[IMPORTANT: The user has invoked the "skill-creator" skill, indicating they want '
"you to follow its instructions. The full skill content is loaded below.]\n\n" "you to follow its instructions. The full skill content is loaded below.]\n\n"
@@ -203,7 +206,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = [] RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient) monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider() provider = OpenVikingMemoryProvider()
provider._client = object() provider._client = cast(Any, object())
provider._endpoint = "http://openviking.test" provider._endpoint = "http://openviking.test"
provider._api_key = "" provider._api_key = ""
provider._account = "default" provider._account = "default"
@@ -220,6 +223,7 @@ class TestOpenVikingSkillQuerySafety:
) )
provider.sync_turn(skill_message, "Done.") provider.sync_turn(skill_message, "Done.")
assert provider._sync_thread is not None
provider._sync_thread.join(timeout=5.0) provider._sync_thread.join(timeout=5.0)
assert RecordingVikingClient.calls == [ assert RecordingVikingClient.calls == [
@@ -237,7 +241,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = [] RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient) monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider() provider = OpenVikingMemoryProvider()
provider._client = object() provider._client = cast(Any, object())
skill_message = ( skill_message = (
'[IMPORTANT: The user has invoked the "skill-creator" skill, indicating they want ' '[IMPORTANT: The user has invoked the "skill-creator" skill, indicating they want '
"you to follow its instructions. The full skill content is loaded below.]\n\n" "you to follow its instructions. The full skill content is loaded below.]\n\n"