seb/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(mcp): preserve loop during probes

Browse Source
This commit is contained in:
helix4u
2026-06-14 02:09:45 -07:00
committed by Teknium
parent 85e6232a07
commit 4936a49a0c
4 changed files with 48 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/tools/test_mcp_probe.py
+2 -2
View File
@@ -162,14 +162,14 @@ class TestProbeMcpServerTools:
assert result["github"][0] == ("my_tool", "")
def test_cleanup_called_even_on_failure(self):
"""_stop_mcp_loop is called even when probe fails."""
"""Probe cleanup is attempted even when probe fails."""
config = {"github": {"command": "npx", "connect_timeout": 5}}
with patch("tools.mcp_tool._MCP_AVAILABLE", True), \
patch("tools.mcp_tool._load_mcp_config", return_value=config), \
patch("tools.mcp_tool._ensure_mcp_loop"), \
patch("tools.mcp_tool._run_on_mcp_loop", side_effect=RuntimeError("boom")), \
patch("tools.mcp_tool._stop_mcp_loop") as mock_stop:
patch("tools.mcp_tool._stop_mcp_loop_if_idle") as mock_stop:
from tools.mcp_tool import probe_mcp_server_tools
result = probe_mcp_server_tools()