seb/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(feishu): fail closed for update prompt card actions

Browse Source
This commit is contained in:
Dusk1e
2026-06-07 06:21:37 -07:00
committed by Teknium
parent 410cb743bf
commit 3fa15b33dd
2 changed files with 125 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/gateway/test_feishu_approval_buttons.py
+72
View File
@@ -642,6 +642,7 @@ class TestCardActionCallbackResponse:
adapter = _make_adapter()
adapter._loop = MagicMock()
adapter._loop.is_closed = MagicMock(return_value=False)
adapter._allowed_group_users = {"ou_bob"}
adapter._update_prompt_state[1] = {
"session_key": "sess-up-1",
"message_id": "msg_up_003",
@@ -667,6 +668,7 @@ class TestCardActionCallbackResponse:
adapter = _make_adapter()
adapter._loop = MagicMock()
adapter._loop.is_closed = MagicMock(return_value=False)
adapter._allowed_group_users = {"ou_user1"}
adapter._update_prompt_state[2] = {
"session_key": "sess-up-2",
"message_id": "msg_up_004",
@@ -717,6 +719,7 @@ class TestCardActionCallbackResponse:
adapter = _make_adapter()
adapter._loop = MagicMock()
adapter._loop.is_closed = MagicMock(return_value=False)
adapter._allowed_group_users = {"ou_user1"}
adapter._update_prompt_state[1] = {
"session_key": "sess-up-1",
"message_id": "msg_up_005",
@@ -754,6 +757,52 @@ class TestCardActionCallbackResponse:
assert response.card is None
mock_submit.assert_not_called()
def test_update_prompt_empty_allowlists_fail_closed(self, _patch_callback_card_types):
adapter = _make_adapter()
adapter._loop = MagicMock()
adapter._loop.is_closed = MagicMock(return_value=False)
adapter._update_prompt_state[7] = {
"session_key": "sess-up-7",
"message_id": "msg_up_007",
"chat_id": "oc_12345",
}
data = _make_card_action_data(
{"hermes_update_prompt_action": "y", "update_prompt_id": 7},
open_id="ou_intruder",
)
with patch("asyncio.run_coroutine_threadsafe") as mock_submit:
response = adapter._on_card_action_trigger(data)
assert response is not None
assert response.card is None
assert 7 in adapter._update_prompt_state
mock_submit.assert_not_called()
def test_update_prompt_chat_mismatch_returns_no_card(self, _patch_callback_card_types):
adapter = _make_adapter()
adapter._loop = MagicMock()
adapter._loop.is_closed = MagicMock(return_value=False)
adapter._allowed_group_users = {"ou_bob"}
adapter._update_prompt_state[8] = {
"session_key": "sess-up-8",
"message_id": "msg_up_008",
"chat_id": "oc_expected",
}
data = _make_card_action_data(
{"hermes_update_prompt_action": "y", "update_prompt_id": 8},
chat_id="oc_mismatch",
open_id="ou_bob",
)
with patch("asyncio.run_coroutine_threadsafe") as mock_submit:
response = adapter._on_card_action_trigger(data)
assert response is not None
assert response.card is None
assert 8 in adapter._update_prompt_state
mock_submit.assert_not_called()
class TestResolveUpdatePrompt:
"""Test update prompt resolution persists the response file."""
@@ -800,3 +849,26 @@ class TestResolveUpdatePrompt:
await adapter._resolve_update_prompt(99, "n", "Nobody")
assert not (tmp_path / ".hermes" / ".update_response").exists()
@pytest.mark.asyncio
async def test_chat_mismatch_does_not_write_response_file(self, tmp_path, monkeypatch):
adapter = _make_adapter()
adapter._allowed_group_users = {"ou_bob"}
monkeypatch.setenv("HERMES_HOME", str(tmp_path / ".hermes"))
(tmp_path / ".hermes").mkdir()
adapter._update_prompt_state[10] = {
"session_key": "sess-up-10",
"message_id": "msg_up_010",
"chat_id": "oc_expected",
}
await adapter._resolve_update_prompt(
10,
"y",
"Bob",
open_id="ou_bob",
chat_id="oc_wrong",
)
assert not (tmp_path / ".hermes" / ".update_response").exists()
assert 10 in adapter._update_prompt_state